This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH/RFA] SH: Rename ashlhi3 insn
Alexandre Oliva <aoliva@redhat.com> wrote:
> This looks good to me. I'd add a comment before the test on
> operands[1] explaining how it is possible that it might not hold,
> given that it's a predicate for operand 1.
How about the comment below?
/* It may be possible to call gen_ashlhi3 directly with more generic
operands. Make sure operands[1] is a HImode register here. */
if (!arith_reg_operand (operands[1], HImode))
operands[1] = copy_to_mode_reg (HImode, operands[1]);
> Also, it would probably be a good idea to try to avoid attempting to
> emit the insn that would violate the predicates in the first place.
Sure.
Regards,
kaz