This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH/RFA] SH: Rename ashlhi3 insn
On Mar 21, 2005, Kaz Kojima <kkojima@rr.iij4u.or.jp> wrote:
> I've started bootstrap with the revised patch below and will
> regtest it. Thanks for your suggestion.
This looks good to me. I'd add a comment before the test on
operands[1] explaining how it is possible that it might not hold,
given that it's a predicate for operand 1.
Also, it would probably be a good idea to try to avoid attempting to
emit the insn that would violate the predicates in the first place.
--
Alexandre Oliva http://www.ic.unicamp.br/~oliva/
Red Hat Compiler Engineer aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist oliva@{lsd.ic.unicamp.br, gnu.org}