This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[patch] tree-into-ssa.c: Remove obsolete comments.
- From: Kazu Hirata <kazu at cs dot umass dot edu>
- To: gcc-patches at gcc dot gnu dot org
- Cc: dnovillo at redhat dot com
- Date: Fri, 18 Mar 2005 18:17:47 -0500 (EST)
- Subject: [patch] tree-into-ssa.c: Remove obsolete comments.
Hi,
Attached is a patch to remove obsolete comments.
AFAIK, we don't build immediate dominator bitmaps. We insert PHI
nodes in a textbook manner by computing dominance frontiers, iterated
dominance frontiers, etc.
Built cc1. OK to apply?
Kazu Hirata
2005-03-18 Kazu Hirata <kazu@cs.umass.edu>
* tree-into-ssa.c: Remove obsolete comments.
Index: tree-into-ssa.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/tree-into-ssa.c,v
retrieving revision 2.45
diff -u -d -p -r2.45 tree-into-ssa.c
--- tree-into-ssa.c 18 Mar 2005 14:02:26 -0000 2.45
+++ tree-into-ssa.c 18 Mar 2005 23:11:10 -0000
@@ -1271,9 +1271,8 @@ mark_def_site_blocks (void)
those variables are removed from the flow graph so that they can
be computed again.
- 2- Compute dominance frontier and immediate dominators, needed to
- insert PHI nodes and rename the function in dominator tree
- order.
+ 2- Compute dominance frontier, needed to insert PHI nodes and
+ rename the function in dominator tree order.
3- Find and mark all the blocks that define variables
(mark_def_site_blocks).
@@ -1319,9 +1318,7 @@ rewrite_into_ssa (bool all)
mark_def_site_blocks ();
- /* Initialize dominance frontier and immediate dominator bitmaps.
- Also count the number of predecessors for each block. Doing so
- can save significant time during PHI insertion for large graphs. */
+ /* Initialize dominance frontier. */
dfs = (bitmap *) xmalloc (last_basic_block * sizeof (bitmap *));
FOR_EACH_BB (bb)
dfs[bb->index] = BITMAP_ALLOC (NULL);