This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PR middle-end/18628] do not fold to label load from tablejumpto reg


On Thu, 2005-03-10 at 17:37 -0300, Alexandre Oliva wrote:
> On Mar 10, 2005, Richard Henderson <rth@gcc.gnu.org> wrote:
> 
> > On Wed, Mar 09, 2005 at 07:26:37AM -0300, Alexandre Oliva wrote:
> >> +		/* If it's not a REG, the REG_EQUAL note is inappropriate.  */
> >> +		if (REG_P (SET_DEST (set)))
> >> +		  set_unique_reg_note (insn, REG_EQUAL, label);
> 
> > I don't think this is a good idea at all.  This is just
> > asking for reload to recreate a reference to the deleted label.
> 
> Here's a patch with that bit removed, along with the change in
> cse_init that it required.  Ok?
BTW, can you open a new bug with the same testcase and attach it to the
"things CSE still catches" meta-bug.  I'd like to catch this at the
tree level if we can rather than wait for our friend CSE.

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]