This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Don't use weak linkage for symbols in COMDAT groups -take 2
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Julian Brown <julian at codesourcery dot com>
- Cc: gcc-patches at gcc dot gnu dot org, julian at gcc dot gnu dot org
- Date: Mon, 07 Mar 2005 20:08:11 -0800
- Subject: Re: [PATCH] Don't use weak linkage for symbols in COMDAT groups -take 2
- Organization: CodeSourcery, LLC
- References: <422D117B.3070900@codesourcery.com>
Julian Brown wrote:
Hi,
This patch stops entities with vague linkage from being declared as ELF
weak symbols when HAVE_GAS_COMDAT_GROUP is true. It was previously
discussed here:
http://gcc.gnu.org/ml/gcc-patches/2005-02/msg01624.html
The patch is dependent on the following Java patch:
http://gcc.gnu.org/ml/gcc-patches/2005-03/msg00712.html
Which fixes the breakage the patch caused before, hopefully.
Tested (with dependent patch applied) on i686-pc-linux-gnu, with all
languages (except ada).
OK to apply, pending previous patch?
Yes, once the Java patch is approved, this one is OK. (There's a minor
style issue in the Java patch; you shouldn't have braces around a 1-line
dependent statement.) I can't comment on the reasonableness of the Java
patch, but hopefully the Java folks will comment soon.
Thanks,
--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304