This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix latent bug in add_referenced_vars

Jan Hubicka <jh@suse.cz> writes:

> Hi,
> Kenny's aliasing code went into problem where static variable never
> passed to backend via cgraph_finalize_variable was listed in referenced
> vars.  This happens because add_referenced_vars walk DECL_INITIAL of
> visited variables.  This is important for contant and static pointers
> that might later be folded into their initializer, what went wrong was
> walking DECL_INITIAL of external variable that according to Mark should
> be consistently ignored by the backend.
>
> Bootstrapped/regtested the attached patch (I also excluded global
> variables as the initializers serve no usefull value either)
>
> Commetted to tree-profiling, OK for mainline?

What about 4.0?  Do we need it there as well?

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 NÃrnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

Attachment: pgp00000.pgp
Description: PGP signature

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]