This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Trivial inliner cleanups
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Richard Guenther <rguenth at tat dot physik dot uni-tuebingen dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 01 Mar 2005 14:47:05 -0800
- Subject: Re: [PATCH] Trivial inliner cleanups
- Organization: CodeSourcery, LLC
- References: <Pine.LNX.4.44.0502281131300.2297-100000@alwazn.tat.physik.uni-tuebingen.de>
Richard Guenther wrote:
This patch does some trivial cleanups to the inliner and related
code, namely exposing a local define to tree-inline.h and using
it in more places instead of 10; removing an unused define and
marking a local helper function inline (it's uses are such that
it will collapse to almost a NOP at most call-sites).
Bootstrapped on x86_64-unknown-linux-gnu.
Ok for mainline?
No, because ...
if (size < 0 || size > MOVE_MAX_PIECES * MOVE_RATIO)
! *count += 10;
... that 10 isn't INSNS_PER_CALL; it's an estimate of how expensive the
copy will be. It should be INSNS_PER_<something else>.
--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304