Re: [patch] Allocate identifier node for user-specified assembler

[Mark Mitchell <mark at codesourcery dot com>]

John David Anglin wrote:

> > It would be better if you could instead avoid relying on this kind of
> > use of identifiers.  These uses are a significant performance impact
> > on GCC and the ability to do them will go away in the future.
>
>
> Are you suggesting that it would be better to do any necessary
> tracking of referenced symbols in the backend?  In the PA case, we only
> need to do this for externals and the number usually isn't that large.

I'm not sure exacty what Geoff's suggesting, but it doesn't seem 
practical to avoid creating the IDENTIFIER_NODE right now.  (As Geoff 
says, it would be nice to do so eventually, but the machinery doesn't 
work that way yet.)

Fortunately, as you say, this code path effects only functions for which 
the user has explicitly specified the assembler name; hopefully, there 
are relatively few in most programs.

I think your patch is correct, and should be applied.  Please go ahead, 
but give Geoff twenty-four hours to object, in case he thinks there's a 
better way to do this in the 4.0 timeframe.

Thanks,

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304