This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[patch] gcse.c: Remove an obsolete comment.
- From: Kazu Hirata <kazu at cs dot umass dot edu>
- To: gcc-patches at gcc dot gnu dot org
- Date: Sun, 20 Feb 2005 19:23:38 -0500 (EST)
- Subject: [patch] gcse.c: Remove an obsolete comment.
Hi,
Attached is a patch to remove an obsolete comment.
These days it shouldn't hurt to create small helper functions as they
are likely to be inlined, especially if they are called only in one
place.
Committed as obvious.
Kazu Hirata
2005-02-20 Kazu Hirata <kazu@cs.umass.edu>
* gcse.c: Remove an obsolete comment.
Index: gcse.c
===================================================================
RCS file: /cvs/gcc/gcc/gcc/gcse.c,v
retrieving revision 1.333
diff -c -d -p -r1.333 gcse.c
*** gcse.c 17 Feb 2005 16:19:32 -0000 1.333
--- gcse.c 20 Feb 2005 23:11:34 -0000
*************** Software Foundation, 59 Temple Place - S
*** 264,282 ****
the result of the expression is copied to a new register, and the redundant
expression is deleted by replacing it with this new register. Classic GCSE
doesn't have this problem as much as it computes the reaching defs of
! each register in each block and thus can try to use an existing register.
!
! **********************
!
! A fair bit of simplicity is created by creating small functions for simple
! tasks, even when the function is only called in one place. This may
! measurably slow things down [or may not] by creating more function call
! overhead than is necessary. The source is laid out so that it's trivial
! to make the affected functions inline so that one can measure what speed
! up, if any, can be achieved, and maybe later when things settle things can
! be rearranged.
!
! Help stamp out big monolithic functions! */
/* GCSE global vars. */
--- 264,271 ----
the result of the expression is copied to a new register, and the redundant
expression is deleted by replacing it with this new register. Classic GCSE
doesn't have this problem as much as it computes the reaching defs of
! each register in each block and thus can try to use an existing
! register. */
/* GCSE global vars. */