This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH to print column numbers in diagnostics
- From: Geert Bosch <bosch at adacore dot com>
- To: Per Bothner <per at bothner dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Sat, 12 Feb 2005 20:26:04 -0500
- Subject: Re: PATCH to print column numbers in diagnostics
- References: <420E748E.7020500@bothner.com>
On Feb 12, 2005, at 16:26, Per Bothner wrote:
This patch prints the column number if non-zero, but only
if USE_MAPPED_LOCATION. So for now it has limited usefulness,
and it may be reasonable to defer until after the branch.
It seems better to make this change after the branch,
as it is somewhat likely that many column numbers
will be imprecise or incorrect, since no one has looked
at them yet. Column numbers can be very useful if one
can rely on them being precise. If not, the usefulness
would be limited and the added information might even be
misleading.
Also, I don't see why this needs to depend on USE_MAPPED_LOCATION.
Front ends that do not use this may still set column numbers.
It is reasonable to expect that when no column number is available,
the column field is set to zero. Where this is not the case currently,
that should be fixed.
So I suggest adding the patch with that change after we branch.