This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] FOR_EACH_RTX construct to replace for_each_rtx

From: Paolo Bonzini <paolo dot bonzini at lu dot unisi dot ch>
To: Richard Henderson <rth at redhat dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Thu, 20 Jan 2005 09:33:36 +0100
Subject: Re: [PATCH] FOR_EACH_RTX construct to replace for_each_rtx
References: <41EE99B0.9090806@lu.unisi.ch> <20050119190053.GD8144@redhat.com> <41EF673F.7000200@lu.unisi.ch> <20050120083208.GA15761@redhat.com>

> Keeping the for_each_rtx idiom of using global variables or > structs-for-parameters (a la replace_label) would not have improved > readability.
But would have simplified reviewing the patch.  Full transition
to some other form should happen in stages.  Not all at once.

I'm sorry, you have a point. Anyway, in my own review, sdiff -b was somewhat helpful.

Paolo

References:
- [PATCH] FOR_EACH_RTX construct to replace for_each_rtx
  - From: Paolo Bonzini
- Re: [PATCH] FOR_EACH_RTX construct to replace for_each_rtx
  - From: Richard Henderson
- Re: [PATCH] FOR_EACH_RTX construct to replace for_each_rtx
  - From: Paolo Bonzini
- Re: [PATCH] FOR_EACH_RTX construct to replace for_each_rtx
  - From: Richard Henderson

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]