This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] tree-cfg.c: Check that a nonlocal label doesn't appearin the middle of a basic block.


Hi Richard,

> > Note that we don't consider a nonlocal label to be appearing in the
> > middle of a basic block if all the statements before the label are
> > also nonlocal labels.
> 
> That would be buggy.  Recall that rtl emits code at each 
> non-local label.  That is why we cannot fallthru to any
> block that contains a non-local label, nor can we merge them.

Oops.  I guess I wrote my patch right but described it wrong.  I
actually misread stmt_starts_bb_p. :-(

My patch should be right because all it does it to call
stmt_starts_bb_p for each label to make sure that it returns false for
all labels after the first one.

Kazu Hirata


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]