This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][Ada] XFAIL ACATS c380004 and c953002, update and import tests from ACATS 2.5L
- From: Eric Botcazou <ebotcazou at libertysurf dot fr>
- To: kenner at vlsi1 dot ultra dot nyu dot edu (Richard Kenner)
- Cc: gcc-patches at gcc dot gnu dot org,roger at eyesopen dot com
- Date: Mon, 10 Jan 2005 23:00:59 +0100
- Subject: Re: [PATCH][Ada] XFAIL ACATS c380004 and c953002, update and import tests from ACATS 2.5L
- References: <10501101952.AA27013@vlsi1.ultra.nyu.edu>
> Nope. The type produced by the front end is definitely wrong and has
> always been. All versions of GNAT since 1.0 have handled this
> "incorrectly" (as defined by this ACATS test). It would work by
> accident on some 32-bit systems one in a while if the overflow was
> missed, but the type is most definitely wrong. The RTS/Front end
> folks can tell you more here.
I don't think this precludes Roger's patch from being valid in general.
The last time I looked at it, it seemed correct to me and was indeed able to
provide better estimates in some cases than the current implementation, which
basically may deduce that A - A will overflow.
Rejecting a patch on anything else than its technical merits seems strange.
--
Eric Botcazou