This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR19100: truthvalue_conversion vs. TREE_OVERFLOW (take3)
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Roger Sayle <roger at eyesopen dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Mark Mitchell <mark at codesourcery dot com>
- Date: Mon, 3 Jan 2005 17:50:38 +0000 (UTC)
- Subject: Re: [PATCH] PR19100: truthvalue_conversion vs. TREE_OVERFLOW (take3)
- References: <Pine.LNX.4.44.0501011815410.11203-100000@www.eyesopen.com>
On Sat, 1 Jan 2005, Roger Sayle wrote:
> * c-common.c (convert_and_check): Avoid testing TREE_OVERFLOW to
> detect conversion overflow, instead use int_fits_type_p.
I don't think there's presently adequate testsuite coverage for the
diagnostics for overflow in implicit constant conversions. (There isn't
*any* coverage for the diagnostics for overflow in arithmetic, but I think
properly testing that the diagnostics for implicit conversions don't
change or only change to fix bugs would suffice for this patch.)
--
Joseph S. Myers http://www.srcf.ucam.org/~jsm28/gcc/
jsm@polyomino.org.uk (personal mail)
joseph@codesourcery.com (CodeSourcery mail)
jsm28@gcc.gnu.org (Bugzilla assignments and CCs)