Re: [PATCH]: New Port ( MAXQ)

["Joseph S. Myers" <joseph at codesourcery dot com>]

On Fri, 31 Dec 2004, Konark Goel, Noida wrote:

> We, at HCL Technologies Ltd, have ported gcc for the MAXQ architecture.
> Although the GCC mainline is in stage 3, 
> but as this port does not affect the generic part so we would request this
> port to be added to the mailine.

License notices should refer to "GCC" rather than "GNU CC".

Please do not include comments on target macro definitions that just 
duplicate the internals manual.  Only include comments on target macro 
definitions where they have something to say specific to that particular 
port.

Please follow the check-list for new targets at 
<http://gcc.gnu.org/onlinedocs/gccint/Back-End.html>.  The options defined 
in TARGET_SWITCHES need documenting.  There appears to be incomplete 
support for some target attributes: maxq_assembler_function_p uses 
lookup_attribute but there is no TARGET_ATTRIBUTE_TABLE definition.  If 
target attributes are to be supported, then they need documenting.  There 
may be other defects.  All functions in maxq.c need a comment above them 
explaining what the function does, its arguments (if any) and its return 
value (if any); see the GNU Coding Standards for details.  Functions with 
no arguments are defined using (void) rather than just ().

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    joseph@codesourcery.com (CodeSourcery mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)