This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: re-apply Kelley's test for old Darwin cctools


On Nov 21, 2004, at 3:04 PM, Per Bothner wrote:
I can't easily *test* such a change,

If it were up to me, I'd say, lets put it in...


After consing up a failing testing environment (see below):

checking assembler for COMDAT group support... (cached) no
checking assembler for COMDAT group support... (cached) no
checking assembler for thread-local storage support... (cached) no
checking assembler for .machine directive support... no
*** This target requires an assembler supporting ".machine"
you can get it from: ftp://gcc.gnu.org/pub/gcc/infrastructure/cctools-528.5.dmg


Looks fine to me. The only thing I didn't test is a, linux x darwin compiler or something like that. I am sure it will work.

How about the attached patch?

I believe your patch addresses all outstanding concerns. Looks good to me.




#!/bin/sh

case "$3" in
        *.s)
                echo "$@"
                grep 'machine' "$3"

grep -q 'machine.*7400' "$3"
if [ "$?" = 0 ]; then echo ".machine 7400 not supported"; exit 1; fi
esac


echo "$@" >>/tmp/as.log

exec /usr/bin/as "$@"



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]