This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: gcc corrections for better pie support
- From: Richard Sandiford <rsandifo at redhat dot com>
- To: "Peter S. Mazinger" <ps dot m at gmx dot net>
- Cc: Thiemo Seufer <ica2_ts at csv dot ica dot uni-stuttgart dot de>, Zack Weinberg <zack at codesourcery dot com>, <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 10 Nov 2004 13:51:42 +0000
- Subject: Re: gcc corrections for better pie support
- References: <Pine.LNX.4.44.0411101442420.6990-200000@lnx.bridge.intra>
"Peter S. Mazinger" <ps.m@gmx.net> writes:
> like the attached?
Yep, looks good to me, thanks. It'll obviously need to be tested
before being applied: let me know what sort of testing you've done.
Also, one small nit:
> #define TARGET_OS_CPP_BUILTINS() \
> do { \
> LINUX_TARGET_OS_CPP_BUILTINS(); \
> - builtin_define ("__PIC__"); \
> - builtin_define ("__pic__"); \
> + if (TARGET_ABICALLS) \
> + { \
> + builtin_define ("__PIC__"); \
> + builtin_define ("__pic__"); \
> + } \
The braces and contents should be indented by 2 more spaces.
Richard