This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] basic_block.h: Move goto_locus from edge to basic_block.
On Wednesday 10 November 2004 06:22, Richard Henderson wrote:
> On Tue, Nov 09, 2004 at 10:01:52AM +0100, Steven Bosscher wrote:
> > Now, rth put the locus on the edge. But think about it:
> > A block that ends in an explicit goto is a block that can have
> > at most one outgoing edge....
>
> Until we start even minimal optimization. Given
>
> if (test)
> goto label;
>
> exactly how long do you think that the goto here will remain a
> distinct basic block?
Perhaps not very long. Fortunately the COND_EXPR for that if would
have a GOTO_EXPR in COND_EXPR_{THEN,ELSE} to put a locus on, so that
doesn't have to be a problem. I don't know if the patch is cafeful
enough about cases like this.
> Methinks yall havn't looked at the results of this patch wrt debug
> info or coverage info at all.
Dunno about that. When you commited your patch to put the locus on
edges, I suppose you've added test cases, haven't you?
Gr.
Steven