This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] tree-if-conv.c: Remove two "if" statements that alwaystrigger.


Hi,

> > Attached is a patch to remove two "if" statements that always trigger.
> > 
> > tree_if_convert_cond_expr receives a COND_EXPR as an argument.  Since
> > this COND_EXPR is a statement and not the one appearing as the rhs of
> > a MODIFY_EXPR, each arm of COND_EXPR always has a GOTO_EXPR.
> > 
> > In tree_if_convert_cond_expr's terms, then_clause and else_clause
> > always have GOTO_EXPR, so we don't need two "if" statements
> 
> Can you put gcc_asserts in their place please?

Nathan said he is OK with the original patch.  Could somebody approve
it please?

Thanks,

Kazu Hirata


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]