This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: zero extend pointer converstions to unsigned long long
- From: Zack Weinberg <zack at codesourcery dot com>
- To: Mike Stump <mrs at apple dot com>
- Cc: "gcc-patches at gcc dot gnu dot org Patches" <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 03 Nov 2004 18:09:04 -0800
- Subject: Re: zero extend pointer converstions to unsigned long long
- References: <20040923230947.GL3721@redhat.com><7C2E84B2-0E62-11D9-8790-003065BDF310@apple.com><20040924201900.GA14392@redhat.com><35734430-127D-11D9-9765-000393941EE6@apple.com><F5E4F089-1661-11D9-8C12-003065A77310@apple.com><A994679B-2C78-11D9-8536-000D9330C092@apple.com><87r7ncsx19.fsf@codesourcery.com><27AB4744-2DFC-11D9-8536-000D9330C092@apple.com>
Mike Stump <mrs@apple.com> writes:
> On Nov 1, 2004, at 8:19 PM, Zack Weinberg wrote:
>> You should be using fold_convert,
>
> Updated.
>
>> and you forgot to validate the changes to the manual (there's an
>> unbalanced squiggle brace, which will cause both makeinfo and
>> texi2dvi to barf). Please fix those.
>
> Updated.
>
> Not sure if you meant, Ok with those changes, or if you want to see
> those changes before this goes in... Anyway, here are the changes...
>
> Ok?
I can't approve this in a state where the test case will fail on some
targets. Please figure out some way to disable the test (or, better,
conditionalize it so it does work) on those targets where it is known
not to work.
I also hesitate to approve this at all given that RTH objected so
strenuously to the original version. I'm of the opinion that it
doesn't make anything any worse than it already was, but I would still
like to hear from him.
zw