Re: RFA: Add dg-require-int-sized-pointers to testsuite

[Janis Johnson <janis187 at us dot ibm dot com>]

On Wed, Nov 03, 2004 at 06:22:31PM +0000, Richard Sandiford wrote:
> Janis Johnson <janis187@us.ibm.com> writes:
> > I'm trying to disentangle my new changes into small patches, but part of
> > what they'll do is add dg-require-effective-target which takes a keyword
> > argument like "lp64", "ilp32", "vmx_hw", and anything else where the
> > corresponding check_* procedure returns a simple 1 or 0.  I'll try to
> > get that piece submitted soon so you can see if you'd like to use that
> > instead of a separate dg-require-int-sized-pointers.
> 
> Thanks, I saw the patch you posted (which looks good to me, FWIW).
> Using { dg-require-effective-target ilp32 } would certainly fix the
> bogus MIPS failures.  Maybe it'd be worth adding a new keyword like
> "ipXX" (or whatever) to indicate that pointers and integers are the
> same size, but there again, maybe that would be overkill.  I don't
> mind either way.

If there are other tests that also care that int and pointer are the
same size then it might be worthwhile to add a check for it rather than
using ilp32; it's certainly easy enough.  My point was that if my patch
is accepted then there's a simpler mechanism for similar checks, and
for using those new keywords in additional places via patches I'll
submit soon.

Janis