This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix bootstrap failure on ppc-darwin
- From: Nathan Sidwell <nathan at codesourcery dot com>
- To: Richard Earnshaw <rearnsha at gcc dot gnu dot org>
- Cc: Geoffrey Keating <geoffk at geoffk dot org>, Andrew Pinski <pinskia at physics dot uc dot edu>,gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 02 Nov 2004 12:48:14 +0000
- Subject: Re: [PATCH] Fix bootstrap failure on ppc-darwin
- Organization: Codesourcery LLC
- References: <28AE3EDD-2A9F-11D9-9310-000A95D692F4@physics.uc.edu> <m2is8qxhdr.fsf@greed.local> <1099393497.11478.109.camel@pc960.cambridge.arm.com>
Richard Earnshaw wrote:
On Mon, 2004-11-01 at 05:33, Geoffrey Keating wrote:
Andrew Pinski <pinskia@physics.uc.edu> writes:
ChangeLog:
* bitmap.h (bmp_iter_end_p): Take a const pointer instead of a struct.
(EXECUTE_IF_SET_IN_BITMAP): Update call to bmp_iter_end_p.
(EXECUTE_IF_AND_COMPL_IN_BITMAP): Likewise.
(EXECUTE_IF_AND_IN_BITMAP): Likewise.
This patch begs the question why we are passing iterators by value at
all. Looking at the code generated for all of these little structures
we see huge numbers of structure copies that aren't being eliminated
even when the iterator functions get inlined.
I have a patch pending which makes the iterators smaller and exclusively
passes the address around.
nathan
--
Nathan Sidwell :: http://www.codesourcery.com :: CodeSourcery LLC
nathan@codesourcery.com :: http://www.planetfall.pwp.blueyonder.co.uk