This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR 18096: Diagnose stack frame overflow in rs6000.c


On Oct 30, 2004, at 9:38 AM, Roger Sayle wrote:
My proposed fix is to tweak "rs6000_emit_allocate_stack" to correctly
use gen_int_mode rather than GEN_INT to correct the problem, but then
to clear my conscience I also check for such an overflow, and generate
a diagnostic warning, and emit a trap instruction, such that if the
function is ever called at run-time we abort rather than introduce
undefined behaviour.

I'm thinking this should be a hard error, not a warning.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]