This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
resubmit ARC patch [was Re: [PATCH] arc backend patch]
- From: Ramana Radhakrishnan <ramana dot radhakrishnan at codito dot com>
- To: Giovanni Bajo <giovannibajo at libero dot it>
- Cc: gcc-patches at gcc dot gnu dot org, rth at redhat dot com
- Date: Fri, 22 Oct 2004 08:38:27 +0530
- Subject: resubmit ARC patch [was Re: [PATCH] arc backend patch]
- References: <4177AD48.8010705@codito.com> <084a01c4b7b8$d8c28a30$f2422597@bagio>
Hi Giovanni,
<snip>
You forgot to specify how you tested this. Did you also test the previous
patch? How did it survive with such a typo?
Yes I did, but somehow while creating the patch from my earlier set of
patches, this seems to have slipped in. I did test this patch by
building GCC again as a cross for arc-elf32 with host i686-linux-gnu.
As an aside, I remember testing this earlier when I submitted this patch
originally at :
http://gcc.gnu.org/ml/gcc-patches/2004-10/msg00961.html
I am resubmitting the patch again which is the reworked original patch
that I had submitted earlier and tested.
Ok to commit ?
Also in 3.3 / 3.4 .
cheers
Ramana
2004-10-22 Ramana Radhakrishnan <ramana.radhakrishnan@codito.com>
* config/arc/lib1funcs.asm(___umulsidi3): The cmp is not required as
it is not a valid instruction on the A4.
Index: lib1funcs.asm
===================================================================
RCS file: /cvs/gcc/gcc/gcc/config/arc/lib1funcs.asm,v
retrieving revision 1.8
diff -c -3 -p -r1.8 lib1funcs.asm
*** lib1funcs.asm 21 Oct 2004 21:52:45 -0000 1.8
--- lib1funcs.asm 22 Oct 2004 03:01:33 -0000
*************** ___umulsidi3:
*** 89,95 ****
nop
beq.nd .Ldone
and.f 0,r0,1 ; if (a & 1)
- cmp r0,0
nop
beq .Ldontadd
add.f r4,r4,r1 ; r += b
--- 89,94 ----