This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix PRs middle-end/15014 and middle-end/16973, removing labels with their address taken

From: Andrew Pinski <pinskia at physics dot uc dot edu>
To: law at redhat dot com
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Mon, 18 Oct 2004 16:18:17 -0400
Subject: Re: [PATCH] Fix PRs middle-end/15014 and middle-end/16973, removing labels with their address taken
References: <2852718A-1614-11D9-81C0-000A95D692F4@physics.uc.edu> <1097015702.22266.583.camel@localhost.localdomain> <1CCD860A-1AE5-11D9-B778-000A95D692F4@physics.uc.edu> <1098127576.2915.29.camel@localhost.localdomain>

On Oct 18, 2004, at 3:26 PM, Jeffrey A Law wrote:

It appears that you move the label to the start of the previous
block, which is probably OK.  I would have moved the label to
the start of the next block which would probably have been less
disruptive in terms of the location of the label.  However, given
the label is not reachable in the flow sense that's probably OK.

Approved.

Thanks.

I also applied the following testcase for PR 16973.

Thanks,
Andrew Pinski

Attachment: temp.diff.txt
Description: Text document

References:
- [PATCH] Fix PRs middle-end/15014 and middle-end/16973, removing labels with their address taken
  - From: Andrew Pinski
- Re: [PATCH] Fix PRs middle-end/15014 and middle-end/16973,removing labels with their address taken
  - From: Jeffrey A Law
- Re: [PATCH] Fix PRs middle-end/15014 and middle-end/16973, removing labels with their address taken
  - From: Andrew Pinski
- Re: [PATCH] Fix PRs middle-end/15014 and middle-end/16973,removing labels with their address taken
  - From: Jeffrey A Law

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]