Re: Patch: GGC-ify type hashtable

[Jan Hubicka <hubicka at ucw dot cz>]

> 
> On Oct 16, 2004, at 4:21 PM, Andrew Pinski wrote:
> 
> >
> >On Oct 16, 2004, at 4:14 PM, Dale Johannesen wrote:
> >
> >>The hashtable for types in c_common_alias_set is not ggc'd, because I 
> >>thought
> >>type nodes would always be pointed to from somewhere else.  After our 
> >>latest
> >>merge it appears that this is no longer true (if it ever was), 
> >>leading to an ICE
> >>building SPEC with IMA.   I have no idea how to construct a small 
> >>testcase.
> >>The fix is obvious.  I am not planning to investigate how the type 
> >>node became
> >>otherwise unreferenced unless somebody thinks this really shouldn't 
> >>happen.
> >>Bootstrapped on Darwin.
> >
> >I also see the same problem with --enable-intermodule and was trying to
> >figure out why, I found the patch which caused it, I think.
> Forgot to say the patch would be:
> http://gcc.gnu.org/ml/gcc-cvs/2004-09/msg00192.html
> 
> Which is connect to PR 17957 so maybe Jan can comment here.

Well, there is not much to comment.  We didn't release the bodies for a
while by mistake and GTYing the pointer we keep around looks like proper
fix.

Honza
> 
> Thanks,
> Andrew Pinski