This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] tree-cfg.c: Speed up cleanup_tree_cfg().

From: "Giovanni Bajo" <giovannibajo at libero dot it>
To: "Diego Novillo" <dnovillo at redhat dot com>
Cc: "Andrew Macleod" <amacleod at redhat dot com>,"Jakub Jelinek" <jakub at redhat dot com>,"Kazu Hirata" <kazu at cs dot umass dot edu>,"gcc-patches" <gcc-patches at gcc dot gnu dot org>
Date: Sat, 2 Oct 2004 03:52:13 +0200
Subject: Re: [patch] tree-cfg.c: Speed up cleanup_tree_cfg().
References: <20041001.090304.48535256.kazu@cs.umass.edu> <09f301c4a7c4$c8bf10d0$f503030a@mimas> <20041001144433.GH31909@devserv.devel.redhat.com> <1096652360.16780.1335.camel@pain> <20041001174441.GK31909@devserv.devel.redhat.com> <1096653778.16780.1349.camel@pain> <05ab01c4a81a$29401c60$dc4e2a97@bagio> <1096680123.8261.3.camel@localhost.localdomain>

Diego Novillo wrote:

> My concern is, actually, new code.  I was also under the impression
> that gcc_assert was a nop in released compilers.  We should have a
> bigger warning sign.

I thought this was explained in details by Nathan, in both documentation and
mails.
http://gcc.gnu.org/ml/gcc-patches/2004-08/msg02264.html

Remember that keeping asserts in release builds can save people from many
silent codegen bugs.

> I guess that a rule of thumb could be "no function calls in gcc_assert
> without ENABLE_CHECKING guards".

Maybe. I kept some RTL-level predicate call if it looked to me lightweight
enough. Nathan also told me that he was going to double-check/refine the
performances of asserts when 4.0 branches.

> I hope this is documented?

http://gcc.gnu.org/ml/gcc-patches/2004-08/msg02239.html

Giovanni Bajo

Follow-Ups:
- Re: [patch] tree-cfg.c: Speed up cleanup_tree_cfg().
  - From: Diego Novillo

References:
- [patch] tree-cfg.c: Speed up cleanup_tree_cfg().
  - From: Kazu Hirata
- Re: [patch] tree-cfg.c: Speed up cleanup_tree_cfg().
  - From: Giovanni Bajo
- Re: [patch] tree-cfg.c: Speed up cleanup_tree_cfg().
  - From: Jakub Jelinek
- Re: [patch] tree-cfg.c: Speed up cleanup_tree_cfg().
  - From: Andrew MacLeod
- Re: [patch] tree-cfg.c: Speed up cleanup_tree_cfg().
  - From: Jakub Jelinek
- Re: [patch] tree-cfg.c: Speed up cleanup_tree_cfg().
  - From: Andrew MacLeod
- Re: [patch] tree-cfg.c: Speed up cleanup_tree_cfg().
  - From: Giovanni Bajo
- Re: [patch] tree-cfg.c: Speed up cleanup_tree_cfg().
  - From: Diego Novillo

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]