This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Use C99 isfinite macro instead of finite when availab
> > But isn't `isfinite' often (always?) a macro? I thought
> > AC_CHECK_FUNCS won't find things if they're only a macro and not in
> > some library as a real function.
>
> I don't know. I just followed the template I found in configure.ac, as
> noone more knowledgeable about autoconf stepped forward to do
> this. Can you write a foolproof autoconf test? (Just checking for
> '#ifdef isfinite' was rejected by Steven up-thread)
> Thanks,
> - Tobi
I think "rejected" is too strong of a wording. Looking back here,
http://gcc.gnu.org/ml/gcc-patches/2004-08/msg01747.html
Steven "wondered" (as-in posed the question) whether we should have a
configure check.
Generally in GCC we don't work by fiat, we try to find the correct
solution. If using AC_CHECK_FUNCS turns out to be wrong, then we
don't use it.
IMHO, the original patch here:
http://gcc.gnu.org/ml/gcc-patches/2004-08/msg00962.html
was correct given that isfinite is a macro not a function (if I'm
correct that AC_CHECK_FUNCS doesn't detect macros.)
Steven - do you have any objection?
--Kaveh
--
Kaveh R. Ghazi ghazi@caip.rutgers.edu