This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PING edge-vector-branch merge


On Thursday 23 September 2004 21:51, Mark Mitchell wrote:
> (...) due to the fact that some people do not
> perceive my reviews as sufficiently objective (...)

I think this is mostly because y'all at CodeSourcery did a lot of
talking about some recent changes internally (for the C++ lexer and
parser patches) and because, frankly, nobody else seemed to care
enough (in the case of the LNO branch merge).

Given that you are one of only 12 people who can approve changes
that touch the entire compiler, and that of those 12, only 2 or 3
actually review patches outside their own area of interest on a
regular basis, I really hope you do not stop reviewing patches just
because "people" "perceive" things.
Especially when there is clearly no possible conflict of interest
between this patch and you with any of your non-RM hats on ;-)

For this particular patch I'd even say you are the *only* person
qualified to approve or reject the patch because you as the RM
decided that this project deserved a chance despite the magnitude
of the change.

So I hope you'll review (and approve :-) the patch.  Waiting more
just complicates matters for bje...

Gr.
Steven



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]