This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PING: Build build programs in a build directory


Kelley Cook wrote:

--- DJ Delorie <dj@redhat.com> wrote:

> >Zack Weinberg wrote:
> > > This looks sound, but I do not feel confident of my ability to
> spot
> > > problems.  Please get a build system maintainer to comment.
> > >
> >
> > This comment was in regards to
> > http://gcc.gnu.org/ml/gcc-patches/2004-09/msg01458.html
> >
> > So I am kindly pinging one of the build the maintainers to review
> it.
>
> Do we know that our bootstrap compilers all support "-o sub/foo.o"
> functionality?

I have no idea if there is a C90 compiler which does not support "-o sub/foo.o". Automake mentions C compilers which don't correctly support -c with -o "are very rare". Nevertheless, I borrowed their macro, so we will use the compile script if this rare compiler actually shows up.

> Otherwise, it looks OK to me.  Ask Mark if it's OK to add at this
> time.

Mark would this be OK assuming that DJ approves of the new change? It does fix a real (though recently papered over by the Java front end) cross-compiling bug and now it also fixes DJ's bug which, if such a compiler exists, also currently exists in the sources. I submitted the original version a few weeks before stage3 was announced.

This patch is OK with me, if DJ approves it. (I have not looked at the patch, but I am happy with the concept.)


--
Mark Mitchell
CodeSourcery, LLC
(916) 791-8304
mark@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]