Re: [C++ PATCH] Fix 14179 - compile-time

[Mark Mitchell <mark at codesourcery dot com>]

Nathan Sidwell wrote:

> Giovanni Bajo wrote:
>
> > !       /* Speed up common initializers (simply a literal).  */
> > !       cp_token* token = cp_lexer_peek_token (parser->lexer);
> > !       cp_token* token2 = cp_lexer_peek_nth_token (parser->lexer, 2);
> > ! !       if (token2->type == CPP_COMMA)
>
> eww!  This really shows that the expression parser should be sped up
> (presumably by removing the recursion and manually tracking the 
> precidence
> level).  I'm not approving this one (but I won't veto someone else
> doing so).  However, if it does go in, how about

I would like to hold off on this patch.  Like Nathan says, this is the 
first good evidence I've seen that implementing operator-precedence 
parsing might be a measureable win on real code.  If you, or Nathan, or 
I, or Zack, or somebody gets to implementing that, then that's probably 
the best way to go.  If not, then we should consider your patch, as it 
really does make a  big difference.  Would you mind reminding me about 
this patch when we get ready to make the release branch, assuming we've 
not yet implemented the operator-precedence thing?

--
Mark Mitchell
CodeSourcery, LLC
(916) 791-8304
mark@codesourcery.com