This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fix tree-optimization/17273




On Fri, 17 Sep 2004, Andrew Pinski wrote:


On Sep 17, 2004, at 11:43 AM, Diego Novillo wrote:



The proper fix for this problem is to remove kill_redundant_phi_nodes, which is trying to do the work of constant and copy propagation. The cleanup work I am doing makes this pass redundant, but it is too invasive for 4.0.

In the meantime, we can work around the problem by telling
kill_redundant_phi_nodes to fold the statement if it makes a constant
replacement.

I don't like we are working around a bug because it is considered too late/invasive for 4.0, remember we are early into stage3 which means that we can have invasive stuff iff it fixes bugs.

This is the way we've always done it. Doing it any other way introduces too many chances for bugs.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]