This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Re-enable warnings for libcpp (build maintainer review requested)


DJ Delorie <dj@redhat.com> writes:

> It looks basically OK to me, except that a reminder: files in config/*
> are shared amonst all the gcc+src projects.  If you move stuff there,
> please keep in mind that other projects should be able to use it also.
> In this specific case, the functionality seems generic enough
> (i.e. libiberty or gdb might use it) but the macros are named in
> gcc-specific ways (GCC_CC_* vs simply CC_* or GCC_*).

Well, the _CC_ infix is intended to mirror Autoconf's own naming
conventions, and the GCC_ prefix was just supposed to indicate where
it came from.  Do you have a suggestion for a more appropriate prefix?
I don't think we have a naming convention for gcc+src-wide autoconf
macros.

> Also, if/when this is committed, the config/* changes will need to be
> committed to src/config as well.

I can do that.  Thanks for the reminder.

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]