This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Add two ObjC++ callback functions to cp/decl.c


Ziemowit Laski wrote:

The patches are occurring in _files_ _belonging_ to the C++ front-end. They affect the C++ front-end only if they prevent the file(s) in question from compiling.

That's true at runtime, but not at edit time. They affect me because there is now more code that I have to look through when trying to understand how things work and more code to change when modifying things. I can't simply ignore the code if I need to modify things; in some cases, your code might not even compile after I make a change.


The SC specifically made Objective-C++ a second-class citizen. So, I'm unsympathetic to your counter-argument that changes to the C++ front end might affect Objective-C++. That was explicitly part of the deal. Another part of the deal, which I will honor, is that we will make every reasonable effort to get Objective-C++ into this next release.

I don't think that you're going to get a lot of pushback on your patches, but I do think you should be sending them for review. Arguing that changes to files in cp/ don't need to be reviewed by a C++ maintainer, after you've been asked to send those patches for review, seems pretty aggressive.

--
Mark Mitchell
CodeSourcery, LLC
(916) 791-8304
mark@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]