This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH] Fix ICE/wrong code with -p on i686-darwin


When Mark rewrite the darwin backend to speed it up, he had messed up
-p for i686-darwin.  When you call
machopic_validate_stub_or_non_lazy_ptr without initializing the
hashtable by calling machopic_ indirection_name, we get an ICE or we get
the wrong code and not be able to assemble it.

There was two ways of fixing this bug, either make FUNCTION_PROFILER
call machopic_indirection_name and removing machopic_mcount_stub_name
or just having machopic_mcount_stub_name do call, I elected to do the
later to make sure that we if there is another use of
machopic_mcount_stub_name anywhere we get the right behavior.


OK? I did a cross compiler build to i686-darwin and a bootstrap on powerpc-apple-darwin and tested it.

Thanks,
Andrew Pinski

ChangeLog:

	* config/darwin.c (machopic_mcount_stub_name): Call
	machopic_indirection_name instead of making the string
	ourselves.



Attachment: temp.diff.txt
Description: Text document



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]