Re: [PATCH] analysis of global statics and removal associated vdefsand vuses

[Mark Mitchell <mark at codesourcery dot com>]

Kenneth Zadeck wrote:

[ a big patch ]

This is OK, with one minor change: the "memory" identifier bit still 
isn't quite what I had in mind.

You're now doing:

+     if (TREE_VALUE (link) == get_identifier("memory"))

That will result in a hash-table lookup on every iteration of the loop. 
 What you want to do is add this identifier node to the global list of 
trees in tree.h, and then initialize it at compiler startup time, so 
that this is simply:

  if (TREE_VALUE (link) == memory_identifier)

It's OK to check this patch in as-is, if you'll agree to make that 
change when you get back from your trip.

Thanks,

--
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com