This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [tree-profiling-branch PATCH] Function cloning + IPCP extension


Hello,

> It looks like we do have two different mechanisms to keep function body
> alive until all clones are processed.  For inline clones we use the
> linked list via next_clone and take advantage of fact that all of them
> do have same DECL node and same hash slot, while for new clones we use
> reference counting.
> 

Since a versioned node has a different FUNCTION_DECL than the original 
node, 
using the same mechanism for keeping the clones seems to be complicated.


> + 
> + /* Remove unreachable nodes. */
> + void
> + cgraph_unreachable_nodes_elimination (void)
> 
> how this is different from cgraph_remove_unreachable_nodes we have
> already?

It seems that calling cgraph_remove_unreachable_nodes
should be done only after the inlining decisions had been made
(as documented in top of the function).

Thanks,
Revital and Razya


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]