Re: [PATCH] Do not look at specs file while building fixincludes

[Bruce Korb <bkorb at veritas dot com>]

Paolo Bonzini wrote:
> 
> > If these fixes are indeed needed, you could use -dM to get the macros
> > predefined by default (whether in cc1 or from specs), but there's no
> > simple solution for any nonconforming macros that might be defined from
> > within cc1 given nondefault options.
> 
> If I understand correctly, the purpose of these fixes is to turn
> 
> #ifdef i686
> 
> into
> 
> #ifdef __i686__
> 
> for example.  The attached patch tries to use both -dM and the specs
> file; it gets i686, unix and linux on my i686-pc-linux-gnu box, while
> HEAD and the previous patch did not find any forbidden identifier.  If
> nobody ever complained, it should be at least enough...
> 
> Bruce, is this ok?

I must apologize; I've been giving priority to my day job :-), so
I haven't looked at it carefully.  I figured I'd stall while you and
Joseph argued ;-).  Anyway, I'd personally _like_ to see fixincludes
become separated from the compiler and become an installable component.
That would make it possible to update the OS and run a simple command
to update the GCC copies of the headers.  It would also require
improvements to the usability of the tool.  The current interface was
focused on compatibility with the old script.

Short answer:  It looks fine to me.  :-)

Cheers - Bruce