This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Shrink struct basic_block, get rid of NOTE_INSN_DISABLE_SCHED_OF_BLOCK
- From: Caroline Tice <ctice at apple dot com>
- To: Richard Henderson <rth at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Zack Weinberg <zack at codesourcery dot com>
- Date: Tue, 24 Aug 2004 14:58:32 -0700
- Subject: Re: Shrink struct basic_block, get rid of NOTE_INSN_DISABLE_SCHED_OF_BLOCK
- References: <87r7pwo569.fsf@codesourcery.com> <20040824212847.GA28716@redhat.com>
PLEASE WAIT!!! The function "clear_bb_flags", which gets call from
try_optimize_cfg (from cleanup_cfg),
wipes out all the information in the bb->flags field, so unless you
modify that function to preserve the
partition flags information this will completely destroy the hot/cold
partitioning optimization.
-- Caroline Tice
ctice@apple.com
On Aug 24, 2004, at 2:28 PM, Richard Henderson wrote:
On Tue, Aug 24, 2004 at 09:46:06AM -0700, Zack Weinberg wrote:
+#define BB_SET_PARTITION(bb, part) ((bb)->flags |= (part))
You need to mask out the old partition bits here.
r~