This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] no lowering of &a.b (and &a->b) in the C front-end


On Sun, 22 Aug 2004, Andrew Pinski wrote:

> > There looks to be something odd about this "+     +" in the patch.
> 
> Hmm, this might be because there was a return there and a tab but it
> looks like the return did not show up in your mailer for some reason.

It seems the problem is format=flowed (RFC2646) and patches don't mix well 
as both use whitespace at ends of lines for their own purposes.  Though 
tabs at ends of lines shouldn't be causing problems in this regard.  (I'd 
suggest in any case that patches shouldn't add lines with whitespace at 
the ends of them outside testsuites, but where an unmodified empty line 
appears in context and so the patch has a space inserted at the start of 
that line, sending in format=flowed still means corrupting the patch by 
removing that space or having it treated as flowing the text.)

-- 
Joseph S. Myers               http://www.srcf.ucam.org/~jsm28/gcc/
    jsm@polyomino.org.uk (personal mail)
    jsm28@gcc.gnu.org (Bugzilla assignments and CCs)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]