This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH]: One declaration of abort
- From: Zack Weinberg <zack at codesourcery dot com>
- To: Nathan Sidwell <nathan at codesourcery dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 20 Aug 2004 08:42:00 -0700
- Subject: Re: [PATCH]: One declaration of abort
- References: <4125B75C.10800@codesourcery.com>
Nathan Sidwell <nathan@codesourcery.com> writes:
> Hi,
> this patch unifies all the declarations of fancy_abort and abort's
> overriding.
>
> The comment in rtl.h & tree.h about system.h getting too much is resolved
> by this patch.
>
> booted & tested on i686-pc-linux-gnu, and building a powerpc-unknown-elf
> cross compiler on same. ok?
This would be OK except for one thing:
> (GCOV_OBJS, GCOV_DUMP_OBJS): Add errors.o.
errors.o is built only for the build machine, whereas gcov is a host
program; i.e. this patch breaks a build != host configuration.
You can correct this by leaving the (elaborated) definition of
fancy_abort in gcov.c, or by adding rules to the Makefile to build two
copies of errors.o, one for build one for host (see the existing
treatment of rtl.c) And if you like to rename all the object files
that are built only for the build machine, so that it's harder to make
this mistake in the future, that would be nice.
zw