This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] More cleanup: inline preserve_subexpressions_p into its callers
- From: Richard Earnshaw <rearnsha at buzzard dot freeserve dot co dot uk>
- To: Richard Earnshaw <rearnsha at buzzard dot freeserve dot co dot uk>
- Cc: Paolo Bonzini <bonzini at gnu dot org>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, rearnsha at buzzard dot freeserve dot co dot uk
- Date: Wed, 18 Aug 2004 00:02:34 +0100
- Subject: Re: [PATCH] More cleanup: inline preserve_subexpressions_p into its callers
>
> bonzini@gnu.org said:
> > 2004-08-13 Paolo Bonzini <bonzini@gnu.org>
> > * calls.c (precompute_register_parameters):
> > Inline preserve_subexpressions_p ().
> > * expmed.c (expand_mult_const, emit_store_flag): Likewise.
> > * optabs.c (expand_binop, expand_twoval_binop, prepare_cmp_insn):
> > Likewise.
> > * expr.c (get_subtarget): Likewise.
> > * rtl.h (preserve_subexpressions_p): Remove.
> > * stmt.c (preserve_subexpressions_p): Remove.
>
> Breaks the build on ARM.
>
> Next time you delete a non-static function from the core of the compiler
> you need to remember to check *all* the back ends, not just the one you
> normally test on.
>
I'll fix the arm port, but note that c4x also uses
preserve_subexpressions_p.
R.