This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: frv: asm reloads for pseudos assigned to memory fail
On Jul 28, 2004, Alexandre Oliva <aoliva@redhat.com> wrote:
> On Jul 28, 2004, Richard Henderson <rth@redhat.com> wrote:
>> Your patch merely papers over the problem.
> I don't think so. If you think the arrangement after the patch could
> still fail, please let me know how.
>> Merge all the move patterns back into one.
> I could, but I'd be reverting someone else's improvement. I'd rather
> not do it unless I'm shown there's something wrong with the it, other
> than the bug I'm fixing in this patch.
We had a long discussion on IRC about why FRV had to be different in
this regard. The reason is that FRV FDPIC doesn't use a fixed PIC
register, and takes care of making sure we won't add new references to
the GOT value during reload. These patterns are part of this.
Richard ended up approving the patch, so I'm checking it in.
--
Alexandre Oliva http://www.ic.unicamp.br/~oliva/
Red Hat Compiler Engineer aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist oliva@{lsd.ic.unicamp.br, gnu.org}