This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] expand_sdiv_pow2 improvements for cmove targets


On Sun, Jul 25, 2004 at 07:31:59AM -0600, Roger Sayle wrote:
> +       /* Construct "temp2 = (temp2 < 0) ? temp : temp2".  */
> +       cmov = gen_rtx_LT (VOIDmode, temp2, const0_rtx);
> +       cmov = gen_rtx_IF_THEN_ELSE (mode, cmov, temp, temp2);
> +       cmov = gen_rtx_SET (mode, temp2, cmov);
> +       emit_insn (cmov);

Why are you building this by hand instead of using emit_conditional_move,
and/or leaving this for ifcvt to handle?  With the latermost option, I'd
simply emit the branch if HAVE_conditional_move is defined.


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]