This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PR 9283] and [PR 15000] Latest version
- From: "Giovanni Bajo" <giovannibajo at libero dot it>
- To: "Niall Douglas" <s_fsfeurope2 at nedprod dot com>
- Cc: <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 21 Jul 2004 20:24:25 +0200
- Subject: Re: [PR 9283] and [PR 15000] Latest version
- References: <40B7BF6C.18450.451E54D7@localhost> (Niall Douglas's message of "Fri, 28 May 2004 22:38:36 +0100") <40FDB2B5.9265.59F76CFB@localhost>
Niall Douglas wrote:
>> Please use underscores between words in names,
>> i.e. DECL_VISIBILITY_SPECIFIED and inlines_hidden. Also, you're
>> missing some spaces before '(' in the opts.c patch. Otherwise, looks
>> good.
>
> Is this sufficient to require me to post another patch? One of you
> could fix these in less than a minute.
"Otherwise good" is the standard way to say "fix these things, and then
commit".
Giovanni Bajo