This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Hookify FUNCTION_ARG_PASS_BY_REFERENCE
Richard Henderson <rth@redhat.com> writes:
> On Wed, Jul 14, 2004 at 08:02:44AM +0100, Richard Sandiford wrote:
>> I think you missed the arrow ;) type has already been checked for null.
> [...]
>> > if (type == NULL_TREE || mode == DImode || mode == DFmode)
>> ------------^^^^^^^^^^^^^^^^^^
>
> Hum. I think this check is buggy then. We'll get different
> answers from a libcall of DCmode and a normal call.
Oh, quite possibly. A lot of the EABI code seems a bit hapzard to me,
and the check above doesn't seem to make much sense. I wasn't trying
to defend it.
Still, the hunk in question is pointless on its own, so I went ahead and
reverted it for now. I'll try to come back to the libcall thing when
I have time...
Richard