This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Hookify FUNCTION_ARG_PASS_BY_REFERENCE


Richard Henderson <rth@redhat.com> writes:
> On Wed, Jul 14, 2004 at 07:40:06AM +0100, Richard Sandiford wrote:
>> > -      size = int_size_in_bytes (type);
>> > +      if (type)
>> > +        size = int_size_in_bytes (type);
>> > +      else
>> > +	size = GET_MODE_SIZE (mode);
>> > +
>> 
>> I don't think this hunk is necessary.
>
> Why not?  I think it is until we remove all traces of libcalls.

I think you missed the arrow ;)  type has already been checked for null.

Richard

----------------------------------------------------------------------

Richard Henderson <rth@redhat.com> writes:
> @@ -7337,7 +7339,11 @@ function_arg_pass_by_reference (const CU
>        if (type == NULL_TREE || mode == DImode || mode == DFmode)
------------^^^^^^^^^^^^^^^^^^
>  	return 0;
>  
> -      size = int_size_in_bytes (type);
> +      if (type)
> +        size = int_size_in_bytes (type);
> +      else
> +	size = GET_MODE_SIZE (mode);
> +

I don't think this hunk is necessary.

Richard


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]