Re: GCC build of HEAD failed for native with your patch on 2004-07-06T18:32:38Z.

[Andrew Pinski <pinskia at physics dot uc dot edu>]

> 
> --BOUNDARY
> Content-Type: text/plain; charset=us-ascii
> Content-Transfer-Encoding: 7bit
> 
> With your recent patch, GCC HEAD does not compile on:
>  native
> Attached is build output for those targets.
> 
> The last time the regression tests were run, GCC did not compile either,
> so the problem might not be caused by your patch.
> 
> For more information, see http://gcc.gnu.org/regtest/.
> 
> /bin/sh ./libtool --mode=compile /Users/regress/tbox/native/build/gcc/xgcc -B/Users/regress/tbox/native/build/gcc/ -B/Users/regress/tbox/objs/powerpc-apple-darwin7.4.0/bin/ -B/Users/regress/tbox/objs/powerpc-apple-darwin7.4.0/lib/ -isystem /Users/regress/tbox/objs/powerpc-apple-darwin7.4.0/include -isystem /Users/regress/tbox/objs/powerpc-apple-darwin7.4.0/sys-include -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DGC_DARWIN_THREADS=1 -DTHREAD_LOCAL_ALLOC=1 -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DSILENT=1 -DNO_SIGNALS=1 -DALL_INTERIOR_POINTERS=1 -DJAVA_FINALIZATION=1 -DGC_GCJ_SUPPORT=1 -DATOMIC_UNCOLLECTABLE=1  -I/Users/regress/tbox/cvs-gcc/gcc/boehm-gc/include -O2 -g -O2  -fexceptions -I././targ-include -I.//libc/include -O2 -g -O2  -fexceptions -I././targ-inc!
 lud
>  e -I.//libc/include  -c -o os_dep.lo /Users/regress/tbox/cvs-gcc/gcc/boehm-gc/os_dep.c
> /Users/regress/tbox/native/build/gcc/xgcc -B/Users/regress/tbox/native/build/gcc/ -B/Users/regress/tbox/objs/powerpc-apple-darwin7.4.0/bin/ -B/Users/regress/tbox/objs/powerpc-apple-darwin7.4.0/lib/ -isystem /Users/regress/tbox/objs/powerpc-apple-darwin7.4.0/include -isystem /Users/regress/tbox/objs/powerpc-apple-darwin7.4.0/sys-include -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\" -DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\" -DGC_DARWIN_THREADS=1 -DTHREAD_LOCAL_ALLOC=1 -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DSILENT=1 -DNO_SIGNALS=1 -DALL_INTERIOR_POINTERS=1 -DJAVA_FINALIZATION=1 -DGC_GCJ_SUPPORT=1 -DATOMIC_UNCOLLECTABLE=1 -I/Users/regress/tbox/cvs-gcc/gcc/boehm-gc/include -O2 -g -O2 -fexceptions -I././targ-include -I.//libc/include -O2 -g -O2 -fexceptions -I././targ-include -I.//libc/include -c /Users/reg!
 res
>  s/tbox/cvs-gcc/gcc/boehm-gc/os_dep.c  -fno-common -DPIC -o .libs/os_dep.o
> /Users/regress/tbox/cvs-gcc/gcc/boehm-gc/os_dep.c:3315: error: static declaration of 'GC_task_self' follows non-static declaration
> /Users/regress/tbox/cvs-gcc/gcc/boehm-gc/os_dep.c:2140: error: previous declaration of 'GC_task_self' was here
> make[3]: *** [os_dep.lo] Error 1
> make[2]: *** [all-recursive] Error 1
> make[1]: *** [all-target-boehm-gc] Error 2
> make: *** [bootstrap] Error 2
> + '[' -s gcc/.bad_compare ']'
> + exit 1


And here is the fix after the recent changes to c-decl.c.
OK?

ChangeLog:
	* os_dep.c (GC_task_self): Declare as static.

Index: os_dep.c
===================================================================
RCS file: /cvs/gcc/gcc/boehm-gc/os_dep.c,v
retrieving revision 1.28
diff -u -p -r1.28 os_dep.c
--- os_dep.c	22 Sep 2003 16:00:23 -0000	1.28
+++ os_dep.c	7 Jul 2004 02:58:57 -0000
@@ -2137,7 +2137,7 @@ GC_bool is_ptrfree;
     /* Using vm_protect (mach syscall) over mprotect (BSD syscall) seems to
        decrease the likelihood of some of the problems described below. */
     #include <mach/vm_map.h>
-    extern mach_port_t GC_task_self;
+    static mach_port_t GC_task_self;
     #define PROTECT(addr,len) \
         if(vm_protect(GC_task_self,(vm_address_t)(addr),(vm_size_t)(len), \
                 FALSE,VM_PROT_READ) != KERN_SUCCESS) { \