This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix for [Bug preprocessor/16366] Preprocessor option -remapcauses memory corruption
- From: Zack Weinberg <zack at codesourcery dot com>
- To: Andris Pavenis <pavenis at latnet dot lv>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 06 Jul 2004 09:53:02 -0700
- Subject: Re: Fix for [Bug preprocessor/16366] Preprocessor option -remapcauses memory corruption
- References: <200407061101.19534.pavenis@latnet.lv>
Andris Pavenis <pavenis@latnet.lv> writes:
> found:
> + /* pfile->file_hash may have been modified if -remap is specified */
> + if (CPP_OPTION (pfile, remap))
> + hash_slot = (struct file_hash_entry **)
> + htab_find_slot_with_hash (pfile->file_hash, fname,
> + htab_hash_string (fname),
> + INSERT);
So neither I nor - as far as I know - *anyone* really understands this
data structure, but I'm pretty sure this is wrong. You're causing it
to store the cached entry under the remapped name, where it will never
be found on lookup.
zw