This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Patch for c/16302

From: Jonathan Lennox <lennox at cs dot columbia dot edu>
To: "Joseph S. Myers" <jsm at polyomino dot org dot uk>
Cc: "Thomas R. Truscott" <trt at cs dot duke dot edu>, gcc-patches at gcc dot gnu dot org
Date: Thu, 1 Jul 2004 13:38:44 -0400
Subject: Re: Patch for c/16302
References: <200407011448.i61EmLOi011526@eenie.cs.duke.edu> <Pine.LNX.4.58.0407011449390.5126@digraph.polyomino.org.uk>

Joseph S. Mywers writes:
> The "sas: " doesn't make sense.  The current style to follow for new 
> warnings doesn't use the ASCII grave accent as an opening quote; instead, 
> use %< as an opening quote and %> for a closing one, so:
> 
> warning ("%<or%> of collectively exhaustive tests is always 1");

Note also that the current style is to phrase warnings like this as
"...always true" and "...always false".  (Note the phrasing of the "limited
range of data type" warning.)

-- 
Jonathan Lennox
lennox@cs.columbia.edu

References:
- Patch for c/16302
  - From: Thomas R. Truscott
- Re: Patch for c/16302
  - From: Joseph S. Myers

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]